driver(docker): opt to set additional dial meta to the client #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
commented
Aug 24, 2023
jedevc
reviewed
Aug 24, 2023
crazy-max
force-pushed
the
driver-client-meta
branch
from
905bee4 to
cdae4c2
Compare
crazy-max
changed the title
crazy-max
force-pushed
the
driver-client-meta
branch
from
cdae4c2 to
082fa36
Compare
crazy-max
force-pushed
the
driver-client-meta
branch
3 times, most recently
from
50664ea to
110f029
Compare
tonistiigi
reviewed
Sep 28, 2023
crazy-max
force-pushed
the
driver-client-meta
branch
2 times, most recently
from
be1f292 to
417dbf8
Compare
crazy-max
force-pushed
the
driver-client-meta
branch
2 times, most recently
from
19394fa to
14ae6f8
Compare
crazy-max
changed the title
This was referenced Oct 12, 2023
crazy-max
force-pushed
the
driver-client-meta
branch
from
14ae6f8 to
cc8d86b
Compare
crazy-max
force-pushed
the
driver-client-meta
branch
from
cc8d86b to
c459ae0
Compare
Adds a new HostGatewayIP entry in the Driver interface so we can move Features and HostGatewayIP handling with cache to the very specific driver (docker). Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
driver-client-meta
branch
from
c459ae0 to
cef117b
Compare
tonistiigi
approved these changes
Oct 16, 2023
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
driver-client-meta
branch
from
cef117b to
511e413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you want some changes apart, it then needs:
In some cases it can be useful to set additional dial metadata to the client.