This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Add an ACL for FORCE_SSL situation. #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When haproxy behind other load balance proxy, such as Amazon ELB, Aliyun SLB. If you use ELB to terminate the SSL, and the haproxy listen on HTTP only, then it will raises the "ERR_TOO_MANY_REDIRECTS" error. But the load balancer can pass a additional X-Forwarded-Proto header to haproxy. So, if we add an ACL to process the X-Forwarded-Proto header, then will solve the problem.
Fix the unit test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When haproxy behind other load balance proxy, such as Amazon ELB, Aliyun SLB. If you use ELB to terminate the SSL, and the haproxy listen on HTTP only, then it will raises the "ERR_TOO_MANY_REDIRECTS" error.
But the load balancer can pass a additional X-Forwarded-Proto header to haproxy. So, if we add an ACL to process the X-Forwarded-Proto header, then will solve the problem.
Must combine with the global env var "SKIP_FORWARDED_PROTO".
#210