Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more options to confirmation popovers... #291

Merged
merged 1 commit into from
Oct 26, 2016
Merged

add more options to confirmation popovers... #291

merged 1 commit into from
Oct 26, 2016

Conversation

ajb
Copy link
Contributor

@ajb ajb commented Oct 26, 2016

...rework the API a little bit, too.

cf #289

I didn't add the advanced positioning, since that would best be
addressed upstream in Bootstrap.


  • ❌ Whether the popover is aligned to the horizontal left, right, or center of the object.
  • ✅ The class(es) of the primary button. (Default: primary)
  • ✅ The class(es) of the secondary button (Default: "no class")
  • ✅ Also, we should remove delete_ from some classes (like popover_delete_confirmation_message to get rid of code smells.)

...rework the API a little bit, too.

cf #289

I didn't add the advanced positioning, since that would best be
addressed upstream in Bootstrap.
@ajb ajb merged commit bdbf9ed into master Oct 26, 2016
@ajb ajb deleted the update-popovers branch October 26, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant