Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved page header styles #161

Merged
merged 1 commit into from
Sep 10, 2015
Merged

Improved page header styles #161

merged 1 commit into from
Sep 10, 2015

Conversation

jrubenoff
Copy link
Contributor

Also easier for those with color blindness to understand which link is active.

screen shot 2015-09-08 at 10 18 46 am

@ajb
Copy link
Contributor

ajb commented Sep 8, 2015

Does this address #136 and #144? If not, can it?

@jrubenoff
Copy link
Contributor Author

Thanks for pointing those out! Fixed #136 and commented on #144. Still need to modify Screendoor accordingly, though.

@ajb
Copy link
Contributor

ajb commented Sep 8, 2015

Awesome, looks great. Just pulled it down and have one comment, which is that the .active text is a bit light for my liking. What do you think of using $bodyFontColor instead of $primaryColor? Or maybe making it bold?

img

@jrubenoff
Copy link
Contributor Author

I like how it looks in Screendoor, so I just added a darker primary color to dvl-core instead.

@ajb
Copy link
Contributor

ajb commented Sep 9, 2015

I don't think we should be using $primaryColor for typography -- think about how it would look on Autodrip where the brand color is #513847. (purple)

I'm gonna make that change, but I'll wait for your 👍 before merging.

@jrubenoff
Copy link
Contributor Author

I want the selected state to be a darker shade of blue, so I just added it as a variable: $linkSelectedColor. Does that work?

- Fix overflow on headers with pagination
- Add $linkSelectedColor variable
@ajb
Copy link
Contributor

ajb commented Sep 10, 2015

👌

ajb added a commit that referenced this pull request Sep 10, 2015
Improved page header styles
@ajb ajb merged commit dd34a1f into master Sep 10, 2015
@ajb ajb deleted the page_header branch September 10, 2015 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants