Merge pull request go-sql-driver#190 from go-sql-driver/cipher_memsafe

ensure cipher memory safety
dngferreira · Dec 8, 2013 · b1aa46e · b1aa46e
2 parents 313606f + afd9edc
commit b1aa46e
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packets.go b/packets.go
@@ -188,9 +188,13 @@ func (mc *mysqlConn) readInitPacket() ([]byte, error) {
 		//	return
 		//}
 		//return errMalformPkt
+		return cipher, nil
 	}
 
-	return cipher, nil
+	// make a memory safe copy of the cipher slice
+	var b [8]byte
+	copy(b[:], cipher)
+	return b[:], nil
 }
 
 // Client Authentication Packet