Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename screenshot tests #1725

Merged
merged 1 commit into from
Nov 16, 2022
Merged

chore: rename screenshot tests #1725

merged 1 commit into from
Nov 16, 2022

Conversation

langz
Copy link
Contributor

@langz langz commented Nov 15, 2022

No description provided.

@langz langz requested a review from tujoworker November 15, 2022 12:51
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 15, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2c1f8bc:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Nov 15, 2022 •
edited
Loading

✅ DNB Eufemia Portal deploy preview ready

tujoworker
tujoworker approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding! We need to remove all png files inside the snapshots folder for the renamed tests – and generate them again. Because they use the test names for the file names. But sadly there is no automation. Yes, I agree, its a little bit cumbersome.

We need anyway to consider to mover over to jest-image-snapshot – they support customSnapshotIdentifier. Even if ours is 10x faster, the docs say – it does not support a custom file name.

@langz langz force-pushed the chore/rename-screenshot-tests branch from cc34974 to 1c44e8c Compare November 15, 2022 13:46
@langz langz force-pushed the chore/rename-screenshot-tests branch from 1c44e8c to 2c1f8bc Compare November 15, 2022 13:53
@langz
Copy link
Contributor Author

langz commented Nov 15, 2022

Nice finding! We need to remove all png files inside the snapshots folder for the renamed tests – and generate them again. Because they use the test names for the file names. But sadly there is no automation. Yes, I agree, its a little bit cumbersome.

We need anyway to consider to mover over to jest-image-snapshot – they support customSnapshotIdentifier. Even if ours is 10x faster, the docs say – it does not support a custom file name.

I'll remember to also remove the "old files" as well 🙏

@langz langz merged commit f393429 into main Nov 16, 2022
@langz langz deleted the chore/rename-screenshot-tests branch November 16, 2022 09:48
@tujoworker
Copy link
Member

🎉 This PR is included in version 9.38.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tujoworker
Copy link
Member

🎉 This PR is included in version 9.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

joakbjerk pushed a commit that referenced this pull request Mar 27, 2023
@langz @joakbjerk
chore: rename screenshot tests (#1725)
12e995e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tujoworker tujoworker tujoworker approved these changes

Assignees
No one assigned
Labels
released on @beta released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langz @tujoworker