refactor: Refactor the sentinel logic

[dm94]

Summary by Sourcery

Refactor the sentinel logic by extracting and organizing methods to improve code readability and maintainability. Update the plugin version to 2.3.6 beta 1.

Enhancements:

• Refactor the sentinel logic by extracting and organizing methods for better readability and maintainability, such as attackLogic, followSameMapLogic, and noSentinelLogic.

Chores:

• Update plugin version from 2.3.5 to 2.3.6 beta 1 in the plugin.json file.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR refactors the sentinel logic in the SentinelModule by breaking down the large onTickModule method into smaller, more focused methods. The changes improve code readability and maintainability by extracting complex logic into separate methods and introducing constants for magic numbers.

Updated class diagram for SentinelModule

classDiagram
    class SentinelModule {
        - Location lastSentinelLocation
        - static double MAX_DISTANCE_LIMIT
        - static int MIN_SENTINEL_HEALTH
        - static double SPEED_MULTIPLIER
        - JLabel label
        + void onTickModule()
        + void attackLogic()
        + void followSameMapLogic()
        + void noSentinelLogic()
        + boolean isAttacking()
        + void changeTarget(Entity target)
        + boolean isOurPet(Entity target)
        + Entity getTargetFromAttackerModules()
        + Entity getSentinelTarget()
        + boolean isSentinelValid()
        + boolean hasSentinel()
        + boolean isPotentialSentinel(Player ship)
        + boolean isTaggedSentinel(Player ship)
        + void goToGroup()
        + boolean isGroupMemberValid(eu.darkbot.api.game.group.GroupMember m)
        + void acceptGroupSentinel()
        + double getRadius(Lockable target)
        + void npcMove()
        + void setNPCConfig(Location direction)
    }

Loading

File-Level Changes

Change	Details	Files
Extracted complex logic into separate methods	Split onTickModule into attackLogic, followSameMapLogic, and noSentinelLogic methods Created changeTarget method to handle target switching logic Extracted target validation into isOurPet and getTargetFromAttackerModules methods Refactored sentinel validation into isSentinelValid and isPotentialSentinel methods	src/main/java/com/deeme/modules/SentinelModule.java
Introduced constants for magic numbers	Added MAX_DISTANCE_LIMIT constant for maximum distance checks Added MIN_SENTINEL_HEALTH constant for sentinel health validation Added SPEED_MULTIPLIER constant for movement calculations	src/main/java/com/deeme/modules/SentinelModule.java
Improved group member handling	Refactored group member processing to use stream operations Extracted group member validation into isGroupMemberValid method	src/main/java/com/deeme/modules/SentinelModule.java
Version bump and minor improvements	Updated version to 2.3.6 beta 1 Added randomization to radius calculation for non-NPC targets Fixed boolean comparison in setNPCConfig method	src/main/java/com/deeme/modules/SentinelModule.java src/main/resources/plugin.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @dm94 - I've reviewed your changes - here's some feedback:

Overall Comments:

• The Boolean.TRUE.equals(runConfigInCircle.getValue()) check is unnecessarily verbose - a simple boolean comparison would be clearer here since getValue() presumably returns a boolean

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Review instructions: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}