Murmurhash byteswapping fix v2 [VDO-5720] #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per suggestion from Eric Biggers on dm-devel, don't use cpu_to_le64 and friends, use get_unaligned_le64 and friends. Call them directly rather than via a wrapper function, since we don't need the conditional mess. Use the same code for user mode, as well. Signed-off-by: Matthew Sakai <[email protected]>
lorelei-sakai
force-pushed
the
fix/builtin-replacement
branch
from
25d3ab4 to
0da5304
Compare
github-actions
bot
added
private testing running
and removed
private testing running
labels
raeburn
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per suggestion from Eric Biggers on dm-devel, don't use cpu_to_le64 and friends, use get_unaligned_le64 and friends. Call them directly rather than via a wrapper function, since we don't need the conditional mess. Use the same code for user mode, as well.
This commit will get squashed with the one from dm-linux/57 to make a v2 patch.