Our test code now assumes that we are using the lvm devices file, #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as this is now the default on most distros. As such we've added cleanup code to handle such situations. - Added an additional check function called checkLVMDevicesFile() that will examine the lvm devices file and remove any orphaned entries. Orphaned entries exist in the file but have no associated device. - Renamed checkLVM to checkDeviceStack and reworked the code to so that it handles all our devices, including the removal of devices from the lvm devices file. - Make sure we don't try to use the devices file if the distro does not support that. Signed-off-by: Bruce Johnston <[email protected]>
github-actions
bot
added
public testing running
public testing failed
and removed
untested
public testing running
labels
github-actions
bot
added
public testing running
and removed
public testing running
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this is now the default on most distros. As such we've added cleanup code to handle such situations.