Rest API: Ends pagination if next page path is not in response.json() #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnash
reviewed
Feb 19, 2024
burnash
requested changes
Feb 19, 2024
burnash
pushed a commit
that referenced
this pull request
Feb 19, 2024
burnash
added a commit
that referenced
this pull request
Mar 22, 2024
* REST API: support all authentication methods (#354) * Generic API client: include parent fields in child resource (#355) * Rest API: Ends pagination if next page path is not in response.json() (#361) * Allow specification of SinglePagePaginator and refactors redundancy (#364) * [REST Source] renames default_paginator argument to paginator (#367) * [REST Source] completes renaming of default_paginator to paginator (#370) * [REST source] test case for dependent resource (#371) * [REST API source] adds function to check connection (#357) * [REST Source] allow skipping http errors (#365) * added the possibility to pass HTTPBasicAuth objects (#377) * [REST] Detailed error handler logging (#383) * [REST source] header_links can extract from responses without a records_path (#382) * [REST source] fixes deprecation warning (#380) * [REST CLIENT] alt response extractor (#396) * Makes openapi friendly auth (#397) * [REST CLIENT] yields data pages with requests context (#399) --------- Co-authored-by: Anton Burnashev <[email protected]> Co-authored-by: Willi Müller <[email protected]> Co-authored-by: mucio <[email protected]> Co-authored-by: rudolfix <[email protected]> Co-authored-by: Steinthor Palsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
References #313
More PR info
The Workable API does not include the json path to the next page for the last page of the response. Thus, this PR catches such cases.