Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: verified sources tests #318

Merged
merged 29 commits into from
Feb 14, 2024
Merged

Fix: verified sources tests #318

merged 29 commits into from
Feb 14, 2024

Conversation

AstrakhantsevaAA
Copy link
Collaborator

@AstrakhantsevaAA AstrakhantsevaAA commented Jan 8, 2024

Tell us what you do here

  • implementing verified source (please link a relevant issue labelled as verified source)
  • fixing a bug (please link a relevant bug report)
  • improving, documenting, customizing existing source (please link an issue or describe below)
  • anything else (please link an issue or describe below)

Relevant issue

issue #

More PR info

fixed tests:

  • chess
  • google analytics
  • google sheets
  • hubspot
  • jira
  • stripe

@AstrakhantsevaAA AstrakhantsevaAA changed the title Fix: chess tests Fix: verified sources tests Feb 6, 2024
sultaniman
sultaniman previously approved these changes Feb 13, 2024
@@ -1 +1,2 @@
dlt>=0.3.22
dlt>=0.4.3a0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be 0.4.4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a big deal :D

)
load_info = pipeline.run(source)
print(load_info)
# # load nothing, because incremental loading and end date limit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did they become flaky should we mark them as flaky if so?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no it works good, it just an example how incremental loading works. I commented it because it will affect tuba project

@AstrakhantsevaAA AstrakhantsevaAA merged commit 756edaa into master Feb 14, 2024
14 checks passed
@AstrakhantsevaAA AstrakhantsevaAA deleted the fix/sources_tests branch February 14, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants