edit snippet to make more runnable #2066
Conversation
Tried running the example as is and ran into a few issues: * dlt[parquet] missing dependency * missing secret (removed since it's not used in this example) * removed serialized flag (this is kind of an advanced feature and not really needed here) * added minimal reflection level, otherwise if you run this script twice in a row you get a "column constraint not supported" kind of error
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@kning absolutely fair comments!
I had to add it to run tests in the snippet, otherwise modal doesn't allow to set @app.function not in the global namespace.
You can modify snippet code in there and move |
|
added changes, is there a good way to see the preview? also what exactly happens in ci, does it run this code at all? |
@kning also trying figure this out, let's create a separate branch and merge your changes there and run CI/CD |
AstrakhantsevaAA
merged commit 1e96dc2
into
dlt-hub:temp/modal_changes
|
preview you can see by this link: https://deploy-preview-2066--dlt-hub-docs.netlify.app/ |
* edit snippet to make more runnable Tried running the example as is and ran into a few issues: * dlt[parquet] missing dependency * missing secret (removed since it's not used in this example) * removed serialized flag (this is kind of an advanced feature and not really needed here) * added minimal reflection level, otherwise if you run this script twice in a row you get a "column constraint not supported" kind of error * move imports into snippet Co-authored-by: Kenny Ning <[email protected]>
Description
Tried running the example as is and ran into a few issues:
Another thing I noticed is that the way the snippets are used in the example excludes information that prevents the code from being truly runnable e.g.
import modalstatementAt a high level, if this is my first time coming to this page, I'd expect to be able to copy / paste the code as is here and run it right away and given how the snippets are set up, that's not the case and I'm not sure how to make it so. Open to ideas!
Related Issues
Additional Context