Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Category Buttons Are Selected When Paths Match #669

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leewyatt
Copy link
Collaborator

@leewyatt leewyatt commented Sep 9, 2024

This PR introduces functionality to the CategorySelectionView to automatically select a category button when its associated path matches the current path. This enhances user experience by visually indicating which category is currently active or being viewed.

Added a listener to sync the selected button with the current path in MobileRouter. This ensures that the selected button always reflects the current route, enhancing navigation consistency.
Copy link
Collaborator

@dlemmermann dlemmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were not selected before? ,,, oh ....so like after a swipe gesture when going back to a previous page?

@leewyatt
Copy link
Collaborator Author

They were not selected before? ,,, oh ....so like after a swipe gesture when going back to a previous page?

Yes, aside from using the back operation, situations like accessing the categories page via the 'More' button on the homepage will result in the button not being selected.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants