Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit in CI #177

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Run pre-commit in CI #177

merged 2 commits into from
Dec 14, 2024

Conversation

mxr
Copy link
Contributor

@mxr mxr commented Dec 13, 2024

This is a followup to #134 to run the pre-commit linters in CI and report errors. See docs at https://github.com/pre-commit/action?tab=readme-ov-file#using-this-action

@barndawgie
Copy link
Contributor

Rather than making this change, I suggest enrolling in https://pre-commit.ci/ which will do this, but better, and keep your pre-commit config up-to-date.

@dlarrick
Copy link
Owner

Rather than making this change, I suggest enrolling in https://pre-commit.ci/ which will do this, but better, and keep your pre-commit config up-to-date.

If this were my day job or this repo saw more than a handful of commits I'd agree, but I think basic tools will be fine here.

@dlarrick dlarrick merged commit 151be99 into dlarrick:master Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants