Proposal: support for certificates for domains with zones in different Azure resource groups #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state
Currently, it is not possible to generate a single certificate for two domains (from two different Azure DNS zones) in two different resource groups, because of how
--dns-azure-resource-group
option works.Example on how DNS zones might be organized in Azure:
domain1.com zone in
group1
resource groupdomain2.com zone in
group2
resource groupMy proposal
Accept multiple resource groups (comma separated) for
--dns-azure-resource-group
. During verification, find resource group for a particular zone when creating / deletingTXT
record.Example usage after the change:
This is a minimal working version. If (from the perspective of an end user) this change is ok, I will refactor the code and add tests / documentation if needed.