Move newScope methods from dclass.d to newScope visitor in dsymbolsem.d
#17038
Conversation
|
Thanks for your pull request and interest in making D better, @dchidindu5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#17038" |
|
Try rebasing on the most recent master, those failures don't immediately seem to be related. |
|
@thewilsonator |
compiler/src/dmd/dsymbolsem.d
Outdated
|
|
||
| override void visit(ClassDeclaration cld) | ||
| { | ||
| auto sc2 = cld.newScope(sc); |
There was a problem hiding this comment.
I don't think you have translated super.newScope here properly. Should be (cast(AggregateDeclaration)cld).newScope(sc);
compiler/src/dmd/dsymbolsem.d
Outdated
|
|
||
| override void visit(InterfaceDeclaration ifd) | ||
| { | ||
| auto sc2 = ifd.newScope(sc); |
There was a problem hiding this comment.
same but `cast(ClassDeclaration)
There was a problem hiding this comment.
Ohh, Let me work on them
| @@ -234,6 +234,7 @@ void test_visitors() | |||
| ClassDeclaration *cd = ClassDeclaration::create(loc, Identifier::idPool("TypeInfo"), NULL, NULL, true); | |||
| assert(cd->isClassDeclaration() == cd); | |||
| assert(cd->vtblOffset() == 1); | |||
There was a problem hiding this comment.
this assert failing means that
if (isCOMinterface() || isCPPinterface())
return 0;
return 1;is returning the wrong value.
Both of those methods should return false for classes (i.e. only for interfaces should they possibly return true). I'm not really sure why that is happening. You might want to check what the actual return value is. If it is 0 or if it is some other value (which would indicate a corrupt vtable on the C++ side).
There was a problem hiding this comment.
It is odd that is only happens with G++/MSVC(???) as the C++ compiler
There was a problem hiding this comment.
okay i'd look at the actual return value
There was a problem hiding this comment.
@thewilsonator I'm a bit lost here, how do I figure that out??
There was a problem hiding this comment.
printf("cd->vtblOffset() = %d\n", cd->vtblOffset());
OPEN SOURCE CONTRIBUTOR