Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/4.1.1 #165

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Release/4.1.1 #165

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e32af10
release 4.1.1 for djangocms-snippet
vipulnarang95 Jul 2, 2024
0d4afa3
updating pyproject.toml
vipulnarang95 Jul 2, 2024
48103a6
Merge branch 'support/django-cms-4.0.x' into release/4.1.1
vipulnarang95 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "djangocms-snippet"
version = "4.1.0"
version = "4.1.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "4.1.1"
dynamic = ["version"]

Does it make sense to make this dynamic?

You would need to add later this later in the file:

[tool.setuptools.dynamic]
version = {attr = "djangocms_snippet.__version__"}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can do this later.. and definitely it makes sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have released the version now. Can you now approve and merge this?

authors = [
{name = "Divio AG", email = "[email protected]"},
]
Expand Down
Loading