-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added re-usable Link widget and JSON endpoint #229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 93.81% 95.35% +1.54%
==========================================
Files 24 27 +3
Lines 291 668 +377
Branches 27 86 +59
==========================================
+ Hits 273 637 +364
- Misses 11 14 +3
- Partials 7 17 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pyproject.toml
Outdated
[build-system] | ||
build-backend = "hatchling.build" | ||
|
||
requires = [ "hatchling" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this sets this project apart from others. Is this something you want to start using across the board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly, that's just convenience: hatchling created the pyproject.toml file automatically. I can see if I can configure it to use setuptools instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used hatchling, so I'm not against it and don't really have any strong opinions on packaging options. So I was mostly curious and I know Jens Erik talked about hatchling a while back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I've seen, the discovery is somewhat smarter. You don't need a MANIFEST.in
file. I guess setuptools grew quite complex over the years. I changed things to setuptools, let's see how it works.
tox.ini
Outdated
{env:COMMAND:coverage} report | ||
|
||
[testenv:flake8] | ||
deps = flake8 | ||
deps = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could consider dropping everything but tests from tox. Because pre-commit and github actions can pick up these.
Then you can get the github tests to install with uv
and install tox
and tox-uv
. This is a similar setup then to what I have here; https://github.com/marksweb/django-nh3/blob/main/.github/workflows/main.yml#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really use tox. Kept it for consistency. I'm fine with removing linting from tox. uv
probably is for performance reasons, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tox just makes running the test suite locally easier - then you can get github to do the same for consistency.
Yeah - uv is just doing things better. (I actually used it to setup a fresh project to show an example of clearing cache from admin recently.)
Co-authored-by: Mark Walker <[email protected]>
…into feat/url-mngr
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We failed to fetch the diff for pull request #229
You can try again by commenting this pull request with @sourcery-ai review
, or contact us for help.
Description
This PR implements the result of discussion django-cms/django-cms#8024 and prepares for django CMS Link 5.0.
LinkWidget
,LinkFormField
, andLinkField
(model field)search_fields
attribute and which have aget_absolute_url
methodOther changes include the update of translations and tests to current Django versions.
Related resources
Checklist
master
Slack to find a “pr review buddy” who is going to review my pull request.