Fix the prevent enum conflict algorithm #225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gist of it is that we look for enum members are dupplicated
inside one namespace but we use a map[string, boolean], (equivalent
to a set[string]) to check for duplicates
the map should be keyed by
$namespace-$memberName
, not justmemberName
the issue is that depending on the order of the processing, we can
override some keys in the map if other namespace have enum members
with the same name. in theory it should not be a problem, but my
implementation was wrong so it turned out to be a problem
At HEAD, fixed:
Before the fix, broken:
In the previous implementation, we don't see the conflic because the value in the map for
VCONFLICT
is overriden by theVCONFLICT
of enums in other namespace then the one that has problem.