Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS Code tooling #266

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Add VS Code tooling #266

merged 1 commit into from
Nov 12, 2024

Conversation

aol-nnov
Copy link
Contributor

@deitch tooling is factored out into this PR.

Comments are welcome!

@deitch
Copy link
Collaborator

deitch commented Nov 12, 2024

A few questions.

First, where did you get the devcontainer configs from? I tend to use standard images, like docker.io/library/golang:<something>. People are more likely to have those.

Second, should the .vscode/ be committed? I usually do not, as those are more personal preferences.

@aol-nnov
Copy link
Contributor Author

where did you get the devcontainer configs from

VS Code did that for me. Just pressed cmd+shift+p and typed few words in! )

image

should the .vscode/ be committed

Few files from that directory indeed should be ignored, but according to canonical gitignore, settings and extensions are allowed. https://www.toptal.com/developers/gitignore/api/visualstudiocode

Also, I'd like to share the corresponding plugin: https://marketplace.visualstudio.com/items?itemName=piotrpalarz.vscode-gitignore-generator which is extremely handy!

@aol-nnov
Copy link
Contributor Author

By the way, should we update the root .gitignore with the help of plugin I'm referring to?

@aol-nnov
Copy link
Contributor Author

Look, I've added the generated file. What do you think?

@deitch
Copy link
Collaborator

deitch commented Nov 12, 2024

Few files from that directory indeed should be ignored, but according to canonical gitignore, settings and extensions are allowed. https://www.toptal.com/developers/gitignore/api/visualstudiocode

I do not know what toptal is, looks like a recruiting site? Although gitignore.io (which is not necessarily authoritative either) recommends the same pattern. 🤷‍♂️

It feels strange to me, trying to tell people what extensions they should install and what settings to use. The recommendations do make sense, though, as it is just recommendations. But should we be including vscode specific stuff in the repo?

In any case, I am not sure about all of those recommendations. For example, I only use the 3rd and 4th. If someone wants the extra, that is fine. Not sure we should be pushing them.

Some of the settings as well, although those, I think, we can live with.

@aol-nnov
Copy link
Contributor Author

I do not know what toptal is, looks like a recruiting site?

Toptal acquired gitignore.io few years ago. All ignore patterns are available on github
and are managed by programming community. I've used gitirnore.io for more than a decade now, different languages, different IDEs. It served me well through years.

what extensions they should install and what settings to use

As for plugins, this is in no way an enforcement, it is a recommendation. When you open the workspace, a popup is showed informing the user about plugins recommended for comfortable development of the current project.

As for settings.json, it is also for consistency. For example, format on save, newline at the end of file - all that essentials.

Anyway, I'm open to any suggestions regarding any of the configs and, on the other side, invite you to try new vscode plugins if you haven't heard of them before. Chances are high, you'll like them!

@deitch
Copy link
Collaborator

deitch commented Nov 12, 2024

Nah, I think it is ok. We always can change it if it gets too rough.

@deitch deitch merged commit 2043c8a into diskfs:master Nov 12, 2024
20 checks passed
@aol-nnov
Copy link
Contributor Author

Yay, cool!

aol-nnov added a commit to aol-nnov/go-diskfs that referenced this pull request Nov 16, 2024
As some fat32 tests need docker, devcontainer needs a tweak for that

Followup for diskfs#266
deitch pushed a commit that referenced this pull request Nov 17, 2024
As some fat32 tests need docker, devcontainer needs a tweak for that

Followup for #266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants