-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VS Code tooling #266
Add VS Code tooling #266
Conversation
A few questions. First, where did you get the devcontainer configs from? I tend to use standard images, like Second, should the |
VS Code did that for me. Just pressed cmd+shift+p and typed few words in! )
Few files from that directory indeed should be ignored, but according to canonical gitignore, settings and extensions are allowed. https://www.toptal.com/developers/gitignore/api/visualstudiocode Also, I'd like to share the corresponding plugin: https://marketplace.visualstudio.com/items?itemName=piotrpalarz.vscode-gitignore-generator which is extremely handy! |
By the way, should we update the root |
dc8fd65
to
d8fd99e
Compare
Look, I've added the generated file. What do you think? |
I do not know what toptal is, looks like a recruiting site? Although gitignore.io (which is not necessarily authoritative either) recommends the same pattern. 🤷♂️ It feels strange to me, trying to tell people what extensions they should install and what settings to use. The recommendations do make sense, though, as it is just recommendations. But should we be including vscode specific stuff in the repo? In any case, I am not sure about all of those recommendations. For example, I only use the 3rd and 4th. If someone wants the extra, that is fine. Not sure we should be pushing them. Some of the settings as well, although those, I think, we can live with. |
Toptal acquired gitignore.io few years ago. All ignore patterns are available on github
As for plugins, this is in no way an enforcement, it is a recommendation. When you open the workspace, a popup is showed informing the user about plugins recommended for comfortable development of the current project. As for settings.json, it is also for consistency. For example, format on save, newline at the end of file - all that essentials. Anyway, I'm open to any suggestions regarding any of the configs and, on the other side, invite you to try new vscode plugins if you haven't heard of them before. Chances are high, you'll like them! |
Nah, I think it is ok. We always can change it if it gets too rough. |
Yay, cool! |
As some fat32 tests need docker, devcontainer needs a tweak for that Followup for diskfs#266
As some fat32 tests need docker, devcontainer needs a tweak for that Followup for #266
@deitch tooling is factored out into this PR.
Comments are welcome!