Closes #250: fat32 8.3 lowercase names, make fs.OpenFile case insensitive for 8.3 and long filenames

[jsando]

Let me know if any changes are required.

I wasn't sure if adding another 10MB fat32 image built with mtools was the best way to go for the unit tests but was a little confused when I tried to add it to the existing fat32.img file, it seems that file is not built by the shell script in the same folder.

[deitch]

I wasn't sure if adding another 10MB fat32 image built with mtools was the best way to go for the unit tests

You are right, it isn't, we should just expand the existing image with some more entries to test these.

but was a little confused when I tried to add it to the existing fat32.img file, it seems that file is not built by the shell script in the same folder.

Yeah. The script to generate it is inline in the testdata/README.md. I had meant to have the script generate it. The problem is that the tests then fail. It is highly sensitive to it, and each regeneration ends up requiring modifying the tests. If you look at ext4, in contrast, it uses standard CLI tools to extract information about the filesystem, and the tests consume those as the expected value. It was not as easy to do with fat32. Maybe I will try, see if I can get it to work.

[deitch]

Yeah, I am getting somewhere. Hang tight.

[deitch]

Done. @jsando rebase on latest, please. The entire fat32.img now is auto-generated with tests, very similar to what I did with ext4. It uses standard tools to inspect it, and then the tests read those outputs to compare with its own values. Works quite well.

You should be able to modify mkfat32.sh as you need.

[jsando]

Rebased and pushed. That was a nice change you did to delete the fat32 test image from git and generate it as part of the build.

Also I saw your comment on the ticket, I will add more information.

[deitch]

That was a nice change you did to delete the fat32 test image from git and generate it as part of the build.

Yeah, it makes things much easier. When initially creating this, you go for easy, or not too much additional effort. At a certain point, the effort of changing all of your fixed test structures because you regenerated one test file becomes too much. Too most of a day, but done.

I like this. The tests are easy to read and understand.

[deitch]

Let CI run, and when clean, we can let it in.

[deitch]

And in. Thank you for finding and fixing this.

[deitch]

I am most curious to know where you are using this. I will drop an email line.