Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create ext4 with correct sizes #248

Merged
merged 1 commit into from
Aug 13, 2024
Merged

create ext4 with correct sizes #248

merged 1 commit into from
Aug 13, 2024

Conversation

deitch
Copy link
Collaborator

@deitch deitch commented Aug 13, 2024

Two ext4 fixes in this:

  • correctly calculate minimum size when 0 provided for defaults
  • correctly calculate max filesystem size for 64-bit and 32-bit. Somehow, it was using bitwise math instead of exponents. I suspect it was a shorthand I wrote and then forgot.

@deitch deitch merged commit e559b1c into master Aug 13, 2024
20 checks passed
@deitch deitch deleted the fix-ext4-min-sectors branch August 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deitch