writable ext4 #243
Merged
writable ext4 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deitch
force-pushed
the
ext4-write
branch
20 times, most recently
from
889b5b1 to
44047d0
Compare
Signed-off-by: Avi Deitcher <[email protected]>
|
This works, surprisingly well. I suspect it will break down with:
But I am happy to merge it in as is, and fix individual issues as they arise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of write functionality for ext4, including tests (of course). The failure cases all work as expected. There do not appear to be any missing write-implementing functions, or any such functions that have missing functionality. However, some of that logic almost certainly is incorrect, as proven by the testing errors.
Anyone who want to assist fixing the functions is welcome.