squashfs: factor read only OpenFile into Open method on directory entry #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to open the file directly from the directory listing which saves doing another directory traversal to find it again.
deitch
approved these changes
Dec 24, 2023
| // Calling this Open method is more efficient than calling | ||
| // FileSystem.OpenFile as it doesn't have to find the file by | ||
| // traversing the directory entries first. | ||
| func (d *directoryEntry) Open() (filesystem.File, error) { |
There was a problem hiding this comment.
I was going to ask, why not have the mode arg here... and then realized, "we are talking about a read-only filesystem, so no point to it." Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables us to open the file directly from the directory listing which saves doing another directory traversal to find it again.
This uses a simple
Openmethod modeled on the one in the zip archive File.OpenWhen extracting all the entries from the archive this makes a significant performance improvement as re-reading all the directory entries from the root is quite expensive.