Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBR: add partition table UUID and partition UUID #198

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

thirdeyenick
Copy link
Contributor

This allows to retrieve the partition table UUID and partition UUID for MBR formatted disks. The partition table UUID (aka "disk identifier" or "disk signature") can be used to identify a disk when using the MBR format scheme. The partition UUID is then just the partition table UUID with the partitions index number appended.

deitch
deitch previously approved these changes Dec 17, 2023
@deitch
Copy link
Collaborator

deitch commented Dec 17, 2023

I was surprised that mbr.initTable() was unused, but apparently it was.

The UUID is optional in MBR, but it cannot hurt, so might as well.

Thank you for this.

@deitch
Copy link
Collaborator

deitch commented Dec 17, 2023

Some linting errors.

This allows to retrieve the partition table UUID and partition UUID for
MBR formatted disks. The partition table UUID (aka "disk identifier" or
"disk signature") can be used to identify a disk when using the MBR
format scheme. The partition UUID is then just the partition table UUID
with the partitions index number appended.
@thirdeyenick
Copy link
Contributor Author

Some linting errors.

Should be fixed now.

@deitch deitch merged commit 3cd0731 into diskfs:master Dec 17, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants