Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squashfs: fix off by one in directory counting #193

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

ncw
Copy link
Contributor

@ncw ncw commented Dec 12, 2023

This was causing "corrupted directory, had 257 entries instead of max
256" errors, however this was because parseDirectoryHeader had already
added one to the count.

Copy link
Collaborator

@deitch deitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but won't pass CI until rebased because of the lint issues that were fixed a few hours ago.

This was causing "corrupted directory, had 257 entries instead of max
256" errors, however this was because parseDirectoryHeader had already
added one to the count.
@ncw ncw force-pushed the fix-dir-counting branch from 85d6150 to 7a484b5 Compare December 14, 2023 13:41
@ncw
Copy link
Contributor Author

ncw commented Dec 14, 2023

Rebased!

@deitch deitch merged commit fa6a9c9 into diskfs:master Dec 14, 2023
19 checks passed
@ncw ncw deleted the fix-dir-counting branch December 14, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants