-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM #1024
Open
calledude
wants to merge
46
commits into
discord-csharp:main
Choose a base branch
from
calledude:wasm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WASM #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Routes/MainLayout component to Wasm project to enable Auto rendering mode
…internal authentication towards the AuthenticationService
…cationStateProvider/AuthState task as needed)
Move RecordsPage to Modix.Models project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is most easily read by going through the commits one by one.
Due to responsiveness being quite sluggish when the user has high latency to the server, I rewrote the webpage into WASM
I tried getting
InteractiveAuto
to work, but we will have to introduce some sort of abstraction to the logic in each controller, so that the server can use those implementations instead of trying to go via a controllerI opted to not do this in this PR due to it being large/long-winded as it is.
I also had to move some models (enums etc) to a shared project, so that the wasm artifact didn't become massive and bring with it a bunch of unnecessary stuff
NOTE: The GuildOption dropdown is slow to load because it's currently bypassing the pre-rendering step due to the server not having
BaseAddress
set.