Discopop project folder structure #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasrothenberger
force-pushed
the
discopop_project/folder_structure
branch
from
17f2bc0 to
3dca9c6
Compare
goerlibe
reviewed
Oct 18, 2023
docs/How_to_contribute.md
Outdated
| ``` | ||
| - project root/ | ||
| - .discopop/ | ||
| - common_data/ |
There was a problem hiding this comment.
I am not completely happy with the "common_data" directory. It adds another hierarchy level which is somewhat unspecified.
Two possible changes:
- simply drop the "common files" into .discopop without another hierarchy level
- interpret the filemapping script as a tool, too --> .discopop/filemapping/FileMapping.txt
There was a problem hiding this comment.
todo: move FileMapping.txt to .discopop
There was a problem hiding this comment.
todo: update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a new folder structure to be used by every tool developed as part of the DiscoPoP project