Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on polysemy-zoo #380

Merged
merged 3 commits into from
May 20, 2024

Conversation

LeitMoth
Copy link
Collaborator

Copied over ConstraintAbsorber, MonadCatch, and Random from polysemy-zoo, so that we can remove it as a dependency. Included the polysemy-zoo license.
Removed Disco's Random.hs file, which only re-exported polysemy-zoo's Random
Updated the needed imports.

@LeitMoth
Copy link
Collaborator Author

I don't think putting the issue number in the name of the pull request properly referenced it.
This should resolve #375.

@LeitMoth
Copy link
Collaborator Author

It also seems that the exact same thing was already done on the ghc-9.8 branch:
f72a7db
So this work may have been redundant.

@byorgey byorgey changed the title Drop dependency on polysemy-zoo, resolves #375 Drop dependency on polysemy-zoo May 20, 2024
@byorgey byorgey linked an issue May 20, 2024 that may be closed by this pull request
@byorgey
Copy link
Member

byorgey commented May 20, 2024

It also seems that the exact same thing was already done on the ghc-9.8 branch:

Hah, oops, I had totally forgotten about that. That's why I was getting deja vu during our meeting this morning. That's OK, we can merge this and I will update the ghc-9.8 branch. And the work was not redundant in the sense that you still learned some things by doing it.

@byorgey
Copy link
Member

byorgey commented May 20, 2024

@LeitMoth Note you'll need to click on Details next to the failed restyled check below and follow the instructions for applying the restyling, then push the new commit. The code copied into our repository needs to conform to our style guidelines.

@byorgey byorgey merged commit 504ec29 into disco-lang:main May 20, 2024
4 checks passed
@LeitMoth LeitMoth deleted the remove-polysemy-zoo branch May 21, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop dependency on polysemy-zoo
3 participants