Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed index out of bounds at body_jacobians #764

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GhostMinerPlus
Copy link

@GhostMinerPlus GhostMinerPlus commented Nov 25, 2024

image
My program panicked at here, then I added an assert like this:
image
And it just failed. I didn't unstand these code well, but I noticed the internal_id of the first new link will be updated to self.links.len(), then I gaussed base_internal_id should be set to self.links.len(), or there will be an unused internal_id. I tested this change with my program and the MultibodyJoint example, it seemed not bad.

@Vrixyz
Copy link
Contributor

Vrixyz commented Nov 29, 2024

Thanks, I'm not very comfortable with the code here either ; can you share more context on what you were doing ? Ideally this would help setting up a test for that ☺️

@GhostMinerPlus
Copy link
Author

GhostMinerPlus commented Dec 5, 2024

Thanks, I'm not very comfortable with the code here either ; can you share more context on what you were doing ? Ideally this would help setting up a test for that ☺️

Ok, I will do it as soon as possible

@GhostMinerPlus GhostMinerPlus force-pushed the master branch 4 times, most recently from 0d8f458 to 185d854 Compare December 21, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants