Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove old style suspension setting #884

Closed
wants to merge 5 commits into from

Conversation

not-nullptr
Copy link
Contributor

sorry - last PR includes an old setting for a more accurate suspension page. this removes the broken setting

@not-nullptr
Copy link
Contributor Author

new commits fix the npm run build command by using archiver instead of adm-zip :3c

@not-nullptr
Copy link
Contributor Author

sorry - trying to get a branch back to the latest commit on this repo

@dimdenGD
Copy link
Owner

there's nothing broken with npm run build

@not-nullptr
Copy link
Contributor Author

with adm-zip, the outputted files are corrupted and won't install in either chrome or firefox. i've been manually zipping the temporary folders to get the build working - archiver seems to actually work

@not-nullptr
Copy link
Contributor Author

OldTwitterFirefox.zip
here's an artifact produced by npm run build-action on the latest commit in this repo. trying to install it will result in an error that it's corrupt, and trying to unzip it using 7-zip shows signs of the zip being corrupted:
image

@dimdenGD
Copy link
Owner

cant reproduce, unpacks fine for me

@not-nullptr
Copy link
Contributor Author

maybe its a node version thing or something? i'm on v20.15.0

@dimdenGD
Copy link
Owner

how is node version related to unpacking a file

@not-nullptr
Copy link
Contributor Author

node version is related to packing the file, not unpacking. modules can break depending on the version you're running - there's clearly some cause of it breaking on my machine

@dimdenGD
Copy link
Owner

you were talking about artifact not local build

@not-nullptr
Copy link
Contributor Author

oh shit sorry i meant local build. my bad

@not-nullptr
Copy link
Contributor Author

anything on this?

@dimdenGD
Copy link
Owner

i don't want to switch zipper

@not-nullptr
Copy link
Contributor Author

does the new one not work on your system or something?

@dimdenGD
Copy link
Owner

i just dont rly trust it and lazy to test if it'll work without bugs

@dimdenGD dimdenGD closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants