Add description field

dimagi · Feb 5, 2024 · 2573dff · 2573dff
1 parent 9addfba
commit 2573dff
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 9 deletions.
diff --git a/superset-frontend/src/components/Datasource/ChangeDatasourceModal.tsx b/superset-frontend/src/components/Datasource/ChangeDatasourceModal.tsx
@@ -200,6 +200,10 @@ const ChangeDatasourceModal: FunctionComponent<ChangeDatasourceModalProps> = ({
   };
 
   const columns = [
+    {
+      Header: t('Description'),
+      accessor: 'description',
+    },
     {
       Cell: ({ row: { original } }: any) => (
         <StyledSpan

diff --git a/superset-frontend/src/features/datasets/DatasetSelectLabel/index.tsx b/superset-frontend/src/features/datasets/DatasetSelectLabel/index.tsx
@@ -27,6 +27,7 @@ type Database = {
 export type Dataset = {
   id: number;
   table_name: string;
+  description?: string;
   datasource_type?: string;
   schema: string;
   database: Database;
@@ -105,17 +106,23 @@ export const DatasetSelectLabel = (item: Dataset) => (
             ? item.table_name
             : t('Not defined')}
         </div>
-        <div className="tooltip-description">
-          <div>
-            {t('Database')}: {item.database.database_name}
+        {item.description ? (
+          <div className="tooltip-description">
+            <div className="tooltip-description">{item.description}</div>
           </div>
-          <div>
-            {t('Schema')}:{' '}
-            {item.schema && isValidValue(item.schema)
-              ? item.schema
-              : t('Not defined')}
+        ) : (
+          <div className="tooltip-description">
+            <div>
+              {t('Database')}: {item.database.database_name}
+            </div>
+            <div>
+              {t('Schema')}:{' '}
+              {item.schema && isValidValue(item.schema)
+                ? item.schema
+                : t('Not defined')}
+            </div>
           </div>
-        </div>
+        )}
       </TooltipContent>
     }
   >

diff --git a/superset-frontend/src/pages/DatasetList/index.tsx b/superset-frontend/src/pages/DatasetList/index.tsx
@@ -306,6 +306,11 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
         size: 'xs',
         id: 'id',
       },
+      {
+        Header: t('Description'),
+        accessor: 'description',
+        size: 'md',
+      },
       {
         Cell: ({
           row: {