Added guidelines around timing #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejenny
requested review from
czue,
dannyroberts,
ctsims,
snopoke,
millerdev,
calellowitz and
esoergel
dannyroberts
approved these changes
Sep 19, 2019
README.md
Outdated
|
|
||
| In extremely rare circumstances where the author and reviewer cannot reach consensus, the review can be escalated, however this should be done in only the most extreme circumstances and should never be necessary if both the author and the reviewer are following the advice below. | ||
|
|
||
| Aim to review PRs within one business day, but use your judgement as to when to break this guideline. Common considerations: |
There was a problem hiding this comment.
The 1-business-day guideline is about your first review of a PR after it's submitted, right? And I think independently also then applies to reviewing the changes someone made in response to your comments?
I.e. we don't expect all of the review, back and forth, and approval to happen in 24 hours except in the simplest of cases (where there reviewer approves without blocking comments). Is that right?
There was a problem hiding this comment.
Good point, will clarify. My understanding is the same as yours.
kaapstorm
approved these changes
Sep 19, 2019
|
Looks good. Thanks for adding to our docs. |
|
👨💻 📖 🔍 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I got out of from today's conversation. Pinged as reviewers anyone who opened their mouth during that conversation. Any objections to saying "review within 24 hours most of the time" and allowing that this isn't set in stone?
@dimagi/team-commcare-hq @shubham1g5