Update code review docs #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wanted to convey the risks are relying too heavily on external links
orangejenny
reviewed
Oct 19, 2022
orangejenny
reviewed
Oct 19, 2022
orangejenny
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Minor changes to the code review and writing PRs docs. I was anticipating making more changes related to some of the takeaways from the code review breakout session at our recent tech summit, but found that most of those values were already expressed well in this document. The only "major" change was to external links not being relied upon indefinitely.
Changeset Category
This PR is streamlined for review in the following category
Safety story