Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create process.rst #12

Merged
merged 4 commits into from
Dec 15, 2021
Merged

Create process.rst #12

merged 4 commits into from
Dec 15, 2021

Conversation

orangejenny
Copy link
Contributor

@ctsims Does this seem useful? It's a bit vague. In practice people submitting non-trivial changes are usually working with an internal contact, so my intent is just for this to help orient people.

@orangejenny orangejenny requested a review from ctsims October 4, 2021 19:18
Copy link
Member

@ctsims ctsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions on wording, mostly since I think it's much better when possible to avoid directly referencing individual codebases for reference (and to push docs into that codebase if unavoidable).

One thought: It might be the case that this doc primarily wants to communicate about QA, and should be focused there instead of a broader contribution doc. IE: Adding a QA doc to docs/ and updating the template at https://github.com/dimagi/open-source/blob/master/templates/CONTRIBUTING.rst to reference it.

docs/process.rst Outdated Show resolved Hide resolved
docs/process.rst Outdated Show resolved Hide resolved
docs/process.rst Outdated Show resolved Hide resolved
orangejenny and others added 3 commits December 15, 2021 09:38
Co-authored-by: Clayton Sims <[email protected]>
Co-authored-by: Clayton Sims <[email protected]>
Co-authored-by: Clayton Sims <[email protected]>
@orangejenny
Copy link
Contributor Author

@ctsims Cool, thanks for feedback. I'm going to leave it framed as a general process doc, because I do want it to be broader than QA. The label process in particular has been a point of confusion, since if you don't have write access your PR immediately fails that check.

@orangejenny orangejenny merged commit 72fa045 into master Dec 15, 2021
@orangejenny orangejenny deleted the orangejenny-patch-1 branch December 15, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants