Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns endpoint actions in entity list response #1472

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

shubham1g5
Copy link
Contributor

Product Description

Adds endpoint Action in entity list response as per spec here

Safety Assurance

Safety story

The change itself is no-op since it only adds endpoint action properties to the entity list response

Automated test coverage

Covered with a new test

QA Plan

None

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

cross-request: dimagi/commcare-core#1342

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1472 (f5c3bd5) into master (0ca4856) will increase coverage by 0.18%.
Report is 21 commits behind head on master.
The diff coverage is 94.11%.

@@             Coverage Diff              @@
##             master    #1472      +/-   ##
============================================
+ Coverage     69.70%   69.88%   +0.18%     
- Complexity     1922     1940      +18     
============================================
  Files           246      250       +4     
  Lines          7552     7594      +42     
  Branches        678      684       +6     
============================================
+ Hits           5264     5307      +43     
  Misses         2023     2023              
+ Partials        265      264       -1     
Files Coverage Δ
...formplayer/beans/menus/EndpointActionResponse.java 100.00% <100.00%> (ø)
...are/formplayer/beans/menus/EntityListResponse.java 90.04% <92.30%> (+0.27%) ⬆️

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shubham1g5 shubham1g5 merged commit a11aa7b into master Oct 5, 2023
3 checks passed
@shubham1g5 shubham1g5 deleted the endpointAction branch October 5, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants