Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Case Search Endpoint Support #1454

Merged
merged 4 commits into from
Sep 12, 2023

Conversation

shubham1g5
Copy link
Contributor

@shubham1g5 shubham1g5 commented Aug 31, 2023

Technical Summary

Adds support for smartlinking inline case search modules as per the spec here

HQ PR and Core PR

The main technical change in the PR is to make the selected_cases instance available to the endpoint stack right after argument processing. This is so that we can use the instance('selected_cases)` expressions in the endpoint stack itself.

Safety Assurance

Safety story

  • Should only affect session endpoint workflows which has wide enough test coverage for different workflows
  • Locally tested

Automated test coverage

d0cd281

QA Plan

None

Special deploy instructions

  • This PR can be deployed after merge with no further considerations.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@shubham1g5 shubham1g5 marked this pull request as draft August 31, 2023 18:33
@shubham1g5 shubham1g5 force-pushed the sessionEndpointWithInlineCaseSearchTest branch from 7aadfb2 to 0adfde9 Compare August 31, 2023 21:08
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1454 (c0645d0) into master (707159d) will increase coverage by 0.03%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1454      +/-   ##
============================================
+ Coverage     69.66%   69.70%   +0.03%     
- Complexity     1918     1920       +2     
============================================
  Files           246      246              
  Lines          7543     7545       +2     
  Branches        676      677       +1     
============================================
+ Hits           5255     5259       +4     
  Misses         2022     2022              
+ Partials        266      264       -2     
Files Changed Coverage Δ
...mmcare/formplayer/services/MenuSessionFactory.java 89.33% <100.00%> (+2.66%) ⬆️
.../formplayer/services/MenuSessionRunnerService.java 78.54% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shubham1g5 shubham1g5 force-pushed the sessionEndpointWithInlineCaseSearchTest branch from 0adfde9 to 8de2633 Compare September 8, 2023 17:51
@shubham1g5 shubham1g5 changed the title Tests for case list endpoints with inline case search enabled Inline Case Search Endpoint Support Sep 11, 2023
@shubham1g5 shubham1g5 marked this pull request as ready for review September 11, 2023 21:48
@shubham1g5 shubham1g5 merged commit 17c1206 into master Sep 12, 2023
@shubham1g5 shubham1g5 deleted the sessionEndpointWithInlineCaseSearchTest branch September 12, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants