PR feedback

payments/views.py

@@ -35,7 +35,6 @@ def update_payment_profile_phone(request):
 
 @api_view(['POST'])
 def confirm_payment_profile_otp(request):
-    PaymentProfile.objects.get(user=request.user)
     payment_profile = request.user.payment_profile
     device = PhoneDevice.objects.get(phone_number=payment_profile.phone_number, user=payment_profile.user)
     if not device.verify_token(request.data.get('token')):
@@ -98,19 +97,18 @@ def post(self, request, *args, **kwargs):
             "approved": [],
             "rejected": [],
         }
-        with transaction.atomic():
-            for profile in profiles:
-                key = (profile.user.username, profile.phone_number)
-                requested_status = status_map.get(key)
+        for profile in profiles:
+            key = (profile.user.username, profile.phone_number)
+            requested_status = status_map.get(key)
 
-                if profile.status != requested_status:
-                    profile.status = requested_status
-                    profiles_to_update.append(profile)
+            if profile.status != requested_status:
+                profile.status = requested_status
+                profiles_to_update.append(profile)
 
-                    usernames_by_states[requested_status].append(profile.user.username)
+                usernames_by_states[requested_status].append(profile.user.username)
 
-            if profiles_to_update:
-                PaymentProfile.objects.bulk_update(profiles_to_update, ['status'])
+        if profiles_to_update:
+            PaymentProfile.objects.bulk_update(profiles_to_update, ['status'])
 
         if usernames_by_states["approved"]:
             send_bulk_message(

utils/twilio.py

@@ -1,6 +1,11 @@
+import logging
+
 from twilio.rest import Client
 from django.conf import settings
 
+
+logger = logging.getLogger(__name__)
+
 # Create the client instance only once
 twilio_client = Client(settings.TWILIO_ACCOUNT_SID, settings.TWILIO_AUTH_TOKEN)
 
@@ -14,4 +19,5 @@ def lookup_telecom_provider(phone_number):
         phone_info = client.lookups.v1.phone_numbers(phone_number).fetch(type="carrier")
         return phone_info.carrier.get("name")
     except Exception as e:
+        logger.exception("Error occurred during twilio call: %s", str(e))
         return None