Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy to json manually #6061

Closed
wants to merge 2 commits into from
Closed

Copy to json manually #6061

wants to merge 2 commits into from

Conversation

esoergel
Copy link
Contributor

wait on build
http://manage.dimagi.com/default.asp?162940
@NoahCarnahan @czue @dannyroberts
It errors on these two lines

The error we were originally getting was because the corresponding config wasn't found, but I think that was a transient issue. When I try to run the task manually, I get a TypeError: cannot deepcopy this pattern object on a save attempt. This appears to be a standing issue with jsonobject, as Danny pointed out. Until a fix for that gets rolled out, this does at least make the config save properly, which lets the task run.

TypeError: cannot deepcopy this pattern object
if ds.get_id == config_id:
return ds
raise BadSpecError(_('The data source referenced by this report could '
'not be found.'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fail hard, if I understand its usage correctly.

@dannyroberts
Copy link
Member

This looks good to go from my perspective. Sorry for the jsonobject bug!

@czue
Copy link
Member

czue commented Mar 26, 2015

@esoergel sorry i wasn't more available today on this, but I don't think this is the right fix. I think the right thing to do is just not call the two failing lines if it is a CustomDataSourceConfiguration. Is there a reason that route didn't work? I'm not exactly sure the best way to do it (would be nice if it didn't get hard-coded right where it's failing but that seems like an okay, and much less obtrusive change than this one)

@esoergel
Copy link
Contributor Author

I've got another branch implementing Cory's suggestion, which seems less impactful, so I'll close this one. (I can't push to github due to the DDoS at this time though)

@esoergel esoergel closed this Mar 27, 2015
@proteusvacuum proteusvacuum deleted the data-source-config branch June 28, 2016 21:48
@snopoke snopoke restored the data-source-config branch March 19, 2017 00:03
@esoergel esoergel deleted the data-source-config branch April 13, 2018 20:50
@snopoke snopoke restored the data-source-config branch August 2, 2018 02:27
@dannyroberts dannyroberts deleted the data-source-config branch March 29, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants