Clean up Invoicing Tests #35576
Open
Clean up Invoicing Tests #35576
+828
−875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Reorganizes and lightly refactors invoicing test suites. Specifically removes
TestDomainInvoiceFactorybecause most of that functionality is already covered inTestInvoice, and in review here it became clear that the distinction was blurry and likely unnecessary.Review by commit.
Safety Assurance
Safety story
Changes automated tests only, no change to functional code.
Automated test coverage
It's automated tests all the way down.
QA Plan
Nope.
Rollback instructions
Labels & Review