Use unwrapped app doc in mobile UCR fixture #35562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping apps is shockingly time consuming, so this has the potential to cut whole seconds off of real world restores
Jtang-1
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
No user-facing changes
Technical Summary
https://dimagi.atlassian.net/browse/USH-5197
Work with unwrapped apps in mobile UCR fixture (behind
RESTORE_ACCESSIBLE_REPORTS_ONLYflag). This saves a significant amount of time in restores - as many as whole seconds. I do have some hesitation about this type of thing in general, as this circumvents any hacks that might be implemented inApplication.wrapmethods, thoughReportAppConfig.wrapis still called.Longer term, I'd love to extract mobile report configs out into SQL, as part of the eventual effort to move Applications out of couch. Given how painful it is to interact with those documents at that size, I think we could see benefits from intermediate stages of the migration, being able to work with only the subsection of the document in question.
Feature Flag
RESTORE_ACCESSIBLE_REPORTS_ONLY: Only restore reports in apps that are accessible to the restoring user.
Safety Assurance
This is behind a feature flag, at least for now. It's also been tested on staging.
Safety story
Automated test coverage
QA Plan
Rollback instructions
Labels & Review