Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Refresh Request Alert For Case Management Page #35300

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

zandre-eng
Copy link
Contributor

Product Description

The following alert is currently being shown on both the Case Management and Case Grouping pages when any polygon filtering changes are made (e.g. new polygon added to map):
Screenshot from 2024-10-30 11-10-58

This alert has now been removed from the Case Management page, and so should now only appear for the Case Grouping page.

Technical Summary

Link to ticket here.

The refresh request alert has been removed from the Case Management page since it is not needed there. Specifically, the alert is required on the Case Grouping page since cases are filtered on the back-end using the polygons specified by the user, hence requiring a page refresh. The same is not true for the Case Management page, and so the alert can safely be removed from this page.

Feature Flag

GEOSPATIAL

Safety Assurance

Safety story

  • Local testing

Very small UI change. Additionally, it has been tested locally to ensure that the alert is still correctly showing for the Case Grouping page.

Automated test coverage

N/A

QA Plan

No QA planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@zandre-eng zandre-eng added the product/feature-flag Change will only affect users who have a specific feature flag enabled label Oct 30, 2024
@zandre-eng zandre-eng marked this pull request as ready for review October 30, 2024 09:15
@zandre-eng zandre-eng force-pushed the ze/remove-refresh-warning-case-management-page branch from 0b515bf to a13bcdf Compare October 30, 2024 15:09
Copy link
Contributor

@ajeety4 ajeety4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zandre for the quick bug fixes for this Page.

@zandre-eng zandre-eng merged commit 1100b4b into master Oct 31, 2024
11 of 12 checks passed
@zandre-eng zandre-eng deleted the ze/remove-refresh-warning-case-management-page branch October 31, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/feature-flag Change will only affect users who have a specific feature flag enabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants