[Code Inspection] Data Cleaning Prototype (HTMX + Alpine) #34846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: corehq/apps/hqwebapp/templatetags/hq_shared_tags.py
Did you find this useful? React with a 👍 or 👎 |
dimagimon
added
dependencies
…atedTableView as base view
snopoke
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Why is this custom loading logic needed? It seems to do the same thing as hx-indicator: https://htmx.org/attributes/hx-indicator/
Comment on lines
+5
to
+6
| hx-swap="outerHTML" | ||
| hq-hx-refresh="{{ table_selector }}"> |
There was a problem hiding this comment.
why are these on the div? I expected to see them on the same element that's making the request.
| hx-post="{{ request.path_info }}{% querystring %}" | ||
| hx-disable-elt="this" | ||
| hq-hx-loading="{{ table.loading_indicator_id }}" | ||
| hx-on::after-request="htmx.trigger('#{{ table.column_manager.filter_form_id }}', 'refreshFilters');"> |
There was a problem hiding this comment.
This seems to duplicate the hq-hx-refresh functionality. Do we need both?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Migrations
Rollback instructions
Labels & Review