Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error when latest version doesn't exist instead of failing silently #34823

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

minhaminha
Copy link
Contributor

Product Description

When using Download Translations there's a tendency for it show a success message when you leave the app version field blank (telling it to use the latest version). It then defaults to the app's current version, which may or may not exist (user could've deleted the latest version and not created a new one). This is a quick fix to make that error known, telling the user to create a new version.

Technical Summary

This was just a bug I found while debugging other things. It only applies to Download Translations.

Feature Flag

Not a feature flag but a domain needs to be configured to use Transifex to access this feature.

Safety Assurance

Safety story

Tested locally. This is safe - it just raises an error when a version its going to try to use isn't valid.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@minhaminha minhaminha added the product/all-users-all-environments Change impacts all users on all environments label Jun 25, 2024
@minhaminha minhaminha merged commit 39530f7 into master Jun 26, 2024
13 checks passed
@minhaminha minhaminha deleted the ml/check-version-pre-transifex branch June 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants