QA-6732: Add type button #34822
Merged
QA-6732: Add type button #34822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimagimon
added
the
Risk: Medium
MartinRiese
requested review from
orangejenny,
AddisonDunn,
stephherbers,
Robert-Costello,
Jtang-1 and
nospame
as code owners
orangejenny
approved these changes
Jun 25, 2024
MartinRiese
force-pushed
the
riese/button
branch
from
a93bbc3 to
2e27cfb
Compare
orangejenny
approved these changes
Jun 25, 2024
stephherbers
approved these changes
Jun 25, 2024
MartinRiese
force-pushed
the
riese/button
branch
from
a67d3f6 to
6b14375
Compare
orangejenny
approved these changes
Jun 26, 2024
orangejenny
approved these changes
Jun 26, 2024
|
I think you're going to want these, too: master...jls/more-buttons |
* Add `type="button"` to add and delete group buttons * Without it they default to `type="submit"` since they are inside a form
* Without it, the button will capture the enter key instead of the submit button
MartinRiese
force-pushed
the
riese/button
branch
from
b0ecffd to
26edc3f
Compare
stephherbers
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
type="button"to add and delete group buttonstype="submit"since they are inside a formTechnical Summary
https://dimagi.atlassian.net/browse/QA-6732
Feature Flag
None
Safety Assurance
Safety story
Automated test coverage
No
QA Plan
See QA ticket
Rollback instructions
Labels & Review