Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_timezone call on exports download page #34759

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

esoergel
Copy link
Contributor

@esoergel esoergel commented Jun 12, 2024

Product Description

Fix 500 error on exports page

Technical Summary

https://dimagi.sentry.io/issues/5479646311/?environment=staging&project=136860&query=is%3Aunresolved+issue.priority%3A[high%2C+medium]&referrer=issue-stream&statsPeriod=1h&stream_index=0
Introduced in #34734
In 9f1a31c, I removed a helper function that was a near duplicate (with a different function signature) of a core util, but I neglected to see if that helper function was referenced in other files. It was, and since it had the same name as the core utility, the other file, the import didn't break. Only when it was called and encountered the different function signature did it actually error.

Feature Flag

Safety Assurance

Safety story

Testing on staging now, but it's pretty straightforward

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@esoergel esoergel requested a review from zandre-eng June 12, 2024 14:12
@esoergel esoergel marked this pull request as ready for review June 12, 2024 17:09
@esoergel esoergel merged commit 27a8276 into master Jun 12, 2024
13 checks passed
@esoergel esoergel deleted the es/fix-timezone branch June 12, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants