Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jquery-migrate #34755

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Remove jquery-migrate #34755

merged 2 commits into from
Jun 12, 2024

Conversation

orangejenny
Copy link
Contributor

Technical Summary

This is leftover from migration jquery to v3 back in 2016.

Safety Assurance

Safety story

Removes a developer tool that isn't in use.

Automated test coverage

no

QA Plan

no

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Jun 11, 2024
@orangejenny orangejenny requested review from millerdev and a team June 11, 2024 18:41
@orangejenny orangejenny requested a review from biyeun as a code owner June 11, 2024 18:41
@dimagimon dimagimon added the dependencies Pull requests that update a dependency file label Jun 11, 2024
@orangejenny orangejenny merged commit adcaf40 into master Jun 12, 2024
12 checks passed
@orangejenny orangejenny deleted the jls/remove-jquery-migrate branch June 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

@biyeun biyeun Awaiting requested review from biyeun biyeun is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file product/invisible Change has no end-user visible impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangejenny @millerdev @dimagimon