Limit batch size for entra api #34754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gherceg
reviewed
Jun 11, 2024
There was a problem hiding this comment.
Looks great! The test failure looks related to the refactor:
corehq.tests.noseplugins.dbtransaction.UnexpectedTransaction: Was an exception raised in setUpClass() after super().setUpClass() or in tearDownClass() before super().tearDownClass()? Context: <class 'corehq.apps.sso.models.IdentityProvider'> does not have the attribute 'get_all_members_of_the_idp'
|
@gherceg Thank you. I fixed the test. |
gherceg
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
Technical Summary
Ticket: https://dimagi.atlassian.net/browse/SAAS-15588
Microsoft Graph API batch requests are limited to 20 individual requests per batch: https://learn.microsoft.com/en-us/graph/json-batching#batch-size-limitations
So I split the list of user_ids to many chunks of size 20.
Also, the error message is not very helpful, here is the Sentry Error. So I append the raw error message from the request to the error message.
Safety Assurance
Safety story
Pretty safe. Because it didn't change much logic, it adds iteration to the batch request, and improve the error message.
Tested on production with CRS's Azure configuration
Rollback instructions
Labels & Review