Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder case properties for bulk case export #34743

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

mkangia
Copy link
Contributor

@mkangia mkangia commented Jun 8, 2024

Product Description

Just a follow up to #34502 to implement order for bulk case exports.

For bulk case exports, when a new bulk export is created or when a bulk export is edited & saved, ordering of columns is set based on data dictionary.
This is different from how it was implemented earlier for exports for a single case type where the ordering was set only while creating the export and not during edit.
This is because, in case exports for a single case type, users can see columns & reorder them on the UI whereas in bulk case export users don't see the columns on the UI.
So, it is safe to reorder columns based on data dictionary for bulk case exports for new and the ones being edited whereas for case exports for single case type, implementing ordering was only done for new exports and not on edit to avoid removing any re-ordering done by users.

This change is limited to projects with access to data dictionary only.

No screenshots attached for reference, simply the excel sheet is populated as ordered columns based on data dictionary set at the time of creation/edit.

Technical Summary

https://dimagi.atlassian.net/browse/SC-3675

Feature Flag

Safety Assurance

Safety story

Tested locally that things work okay for bulk case exports.
Code changes are quite limited and should not impact anything about exports otherwise.

Automated test coverage

Added tests for new code added.

QA Plan

Will go through QA considering this is a user facing change.
QA request submitted. https://dimagi.atlassian.net/browse/QA-6656

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@mkangia mkangia added the product/all-users-all-environments Change impacts all users on all environments label Jun 9, 2024
@mkangia mkangia marked this pull request as ready for review June 9, 2024 05:39
@mkangia mkangia requested a review from zandre-eng June 9, 2024 05:39
@mkangia mkangia merged commit c9292f1 into master Jun 20, 2024
13 checks passed
@mkangia mkangia deleted the mk/3675-bulk-case-exports-order-columns branch June 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments QA Passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants