Merge pull request #33716 from dimagi/jt/custom-gateway-host-setting-…

…validation Custom Gateway Form Validation for "Host"
dimagi · Nov 9, 2023 · 79eda90 · 79eda90
2 parents e335dcf + 016cc11
commit 79eda90
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/corehq/apps/email/forms.py b/corehq/apps/email/forms.py
@@ -18,10 +18,10 @@ class EmailSMTPSettingsForm(forms.ModelForm):
         widget=forms.PasswordInput(render_value=True),
     )
 
-    server = forms.URLField(
+    server = forms.CharField(
         label=_('Server'),
         required=True,
-        help_text=_('e.g. "https://smtp.example.com"'),
+        help_text=_('e.g. "smtp.example.com"'),
     )
 
     port = forms.IntegerField(

diff --git a/corehq/apps/email/tests/test_email_form.py b/corehq/apps/email/tests/test_email_form.py
@@ -55,19 +55,6 @@ def test_clean_from_email(self):
         self.assertFalse(form.is_valid())
         self.assertIn('from_email', form.errors)
 
-    def test_clean_server(self):
-        form_data = EmailSMTPSettingsFormTests._get_valid_form_data()
-
-        # Valid server format
-        form = EmailSMTPSettingsForm(data=form_data)
-        self.assertTrue(form.is_valid())
-
-        # Invalid server format
-        form_data.update({'server': 'server'})
-        form = EmailSMTPSettingsForm(data=form_data)
-        self.assertFalse(form.is_valid())
-        self.assertIn('server', form.errors)
-
     @staticmethod
     def _get_valid_form_data():
         return {